test(NODE-5761): skip azure oidc tests #3931
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| run_on: ubuntu2004-small | ||
| batchtime: 20160 | ||
| tasks: | ||
| - testazureoidc_task_group |
There was a problem hiding this comment.
Is there a reason a similar TODO(DRIVERS-2416/NODE4929) comment wasn't left in this file? Is it just assumed?
There was a problem hiding this comment.
config.yml is generated from config.in.yml so the comments get filtered out. So we put them always in config.in.yml which is the file we edit.
There was a problem hiding this comment.
Ahh I see, apologies for the delay in responding. LGTM
nbbeeken
added
the
Primary Review
aditi-khare-mongoDB
approved these changes
Nov 29, 2023
nbbeeken
approved these changes
Nov 30, 2023
aditi-khare-mongoDB
added
Team Review
aditi-khare-mongoDB
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Doesn't actually skip the Azure OIDC tests but removes them from the matrix as the failures are in the setup from the drivers tools scripts.
What is changing?
Removes the variant from the matrix with a todo.
Is there new documentation needed for these changes?
None
What is the motivation for this change?
NODE-5761
Double check the following
npm run check:lintscripttype(NODE-xxxx)[!]: descriptionfeat(NODE-1234)!: rewriting everything in coffeescript